Open
Conversation
Contributor
Author
|
I believe there is an error in the detect_minima kernel because it does not seem to always detect the minimum value when it is located at the bottom or on the right edge of the matrix. edit: : I noticed the same problem for the detect_maxima kernel. I also added a test in which detecting the minimal/maximal value when it is located in the center of a 3D array does not work. |
StRigaud
reviewed
Apr 13, 2023
Comment on lines
+10
to
+15
| { | ||
| std::string cl_header = { | ||
| #include "cle_detect_minima.h" | ||
| }; | ||
| this->SetSource("detect_minima", cl_header); | ||
| } |
Member
There was a problem hiding this comment.
Library was updated, this need to be changed as followed:
- move the include outside the function, at the top of the file
- replace
cl_headerbyoclKernel::detect_minima
see: absolute kernel for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.